Add BSA class with pplite backend. #86
Conversation
|
Please merge the master branch to resolve conflicts |
| return self._polyhedron.is_universe() | ||
|
|
||
|
|
||
| class BasicSemialgebraicSet_polyhedral_pplite_NNC_Polyhedron(BasicSemialgebraicSet_polyhedral): |
There was a problem hiding this comment.
I'd suggest moving this new class into a separate file basic_semialgebraic_pplite
| # old Sage | ||
| from sage.libs.ppl import Variable, Constraint, Linear_Expression, Constraint_System, NNC_Polyhedron, Poly_Con_Relation, Poly_Gen_Relation, Generator, MIP_Problem, point as ppl_point | ||
|
|
||
| from pplite import Variable as pplite_Var, Constraint as pplite_Con, Linear_Expression as pplite_Lin_Expr, Affine_Expression as pplite_Aff_expr, NNC_Polyhedron as pplite_NNC_Polyhedron, PPliteGenerator, Polyhedron_Constraint_Rel, Polyhedron_Generator_Rel |
There was a problem hiding this comment.
this shouldn't be imported unconditionally because we don't want to make pplite a mandatory dependency.
see below -- best put this new pplite material in a separate file
| # logging.warning("max number %s of bounds propagation iterations has attained." % max_iter) | ||
| bounds_propagation_iter += 1 | ||
|
|
||
| class BasicSemialgebraicSet_polyhedral_Normaliz_semiopen_polyhedron(BasicSemialgebraicSet_polyhedral): |
There was a problem hiding this comment.
Also the new (unfinished?) Normaliz stuff should probably go in a separate file basic_semialgebraic_normaliz
requirements.txt
Outdated
| sphinxcontrib-bibtex | ||
| sphinxcontrib-websupport | ||
| pynormaliz | ||
| pplite |
There was a problem hiding this comment.
This should be pplitepy -- https://pypi.org/project/pplitepy/
| from __future__ import division, print_function, absolute_import | ||
|
|
||
| from . import basic_semialgebraic, big_cells, polyhedral_complex, real_set | ||
| from . import basic_semialgebraic, basic_semialgebraic_2, big_cells, polyhedral_complex, real_set |
ComboProblem
force-pushed
the
PPlite_BSA
branch
6 times, most recently
from
e39df09 to
d54735f
Compare
ComboProblem
force-pushed
the
PPlite_BSA
branch
from
d54735f to
0ccacce
Compare
|
I've made the requested changes. I removed the normaliz stuff since normaliz doesn't seem to be supported as a sage backend right now, so this PR is strictly the pplite backend. |
2 participants
see title