Skip to content

Conversation

@ComboProblem
Copy link
Contributor

The now correct branch...

Summary of Changes:

  • Implemented methods to support partially defined evaluations in ParametricRealField. The implementation assumes partially defined evaluations are true. Determining if a ParametricRealField has consistent inequalities is partially shifted to the underlying BSA when dealing with variables without a test value.
  • Updated tests to reflect changes as needed.
  • Currently, the test coverage passing at same rate as in the current version (afik).
  • Moved FactorUndetermined to a shared folder as it is used in both spam and igp folders.
  • codespell and pycodestyle-minimal linting on parametric.sage and parametric_real_field_element.py

@ComboProblem ComboProblem force-pushed the partial_test_point_impl branch from fc8a062 to 4f19888 Compare October 1, 2025 00:10
@ComboProblem
Copy link
Contributor Author

As a note, when I test this with a full sagemath (10.5) installation these changes work as intended.
When I run this branch with the passagemath installation as per the instructions, something fails.

@mkoeppe
Copy link
Owner

mkoeppe commented Oct 3, 2025

  • Moved FactorUndetermined to a shared folder as it is used in both spam and igp folders.

Let's not do that. cutgeneratingfunctionology.spam is already a dependency of .igp via parametric.sage. Just define the exception somewhere in .spam

@mkoeppe
Copy link
Owner

mkoeppe commented Oct 3, 2025

(Eventually, I want to move other bits from parametric.sage, in particular the ParametricRealField parent class, to .spam.)

@ComboProblem
Copy link
Contributor Author

I've moved all the parametric field exceptions into a file in .spam and updated some documentation of a test that behavior has changed with the implementation partial evaluations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants