Skip to content

Conversation

@benoit-cty
Copy link
Contributor

@benoit-cty benoit-cty commented Nov 3, 2025

Description

Add carbonboard PNG's to package.

Related Issue

Please link to the issue this PR resolves: will close #957

Motivation and Context

Missing images in carbonboard.

How Has This Been Tested?

uv build

...
adding 'codecarbon/viz/assets/car_icon.png'
adding 'codecarbon/viz/assets/house_icon.png'
adding 'codecarbon/viz/assets/tv_icon.png'
...

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

adding 'codecarbon/viz/assets/car_icon.png'
adding 'codecarbon/viz/assets/house_icon.png'
adding 'codecarbon/viz/assets/tv_icon.png'
Copy link
Collaborator

@inimaz inimaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benoit-cty LGTM!

@inimaz inimaz merged commit e7ec872 into master Nov 4, 2025
11 checks passed
@inimaz inimaz deleted the fix/missing_ressources_carbonboard branch November 4, 2025 08:02
SaboniAmine pushed a commit that referenced this pull request Nov 4, 2025
adding 'codecarbon/viz/assets/car_icon.png'
adding 'codecarbon/viz/assets/house_icon.png'
adding 'codecarbon/viz/assets/tv_icon.png'

Co-authored-by: benoit-cty <4-benoit-cty@users.noreply.git.leximpact.dev>
@benoit-cty benoit-cty mentioned this pull request Nov 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Carbon board assets not installed with package

3 participants