Skip to content

Conversation

@cianc
Copy link
Contributor

@cianc cianc commented Nov 22, 2025

Description

By adding a unit test to validate headers for an empty file, file_test.py now covers all cases covered by test_fileoutput_has_valid_headers.py and we can remove that file.

Related Issue

Please link to the issue this PR resolves: #972

Motivation and Context

Removes redundant test code.

How Has This Been Tested?

Ran all existing unit tests and added a new one.

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…pty file. This allows removing test_fileoutput_has_valid_headers.py which is now completley redundant.
@cianc cianc marked this pull request as ready for review November 22, 2025 17:33
@cianc cianc requested a review from a team as a code owner November 22, 2025 17:33
Copy link
Member

@SaboniAmine SaboniAmine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@SaboniAmine SaboniAmine merged commit 3e9fc9f into master Nov 22, 2025
5 checks passed
@cianc cianc deleted the tests/fileoutput_cleanup branch November 22, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tests] Add unit tests to the output methods

3 participants