Skip to content

Conversation

@inimaz
Copy link
Collaborator

@inimaz inimaz commented Nov 29, 2025

Description

As suggested by @cianc. Add logfire to the job that runs the tests of codecarbon in wheel mode. See original discussion for more info.

Related Issue

Please link to the issue this PR resolves: [issue #]

Motivation and Context

Why is this change required? What problem does it solve?

How Has This Been Tested?

Please describe in detail how you tested your changes.

Screenshots (if appropriate):

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@inimaz inimaz requested a review from a team as a code owner November 29, 2025 14:07
Copy link
Contributor

@benoit-cty benoit-cty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

LogFire was added in dev deps by #989

But I think the wheel only install main deps and not dev, so it's good.

@inimaz inimaz merged commit dc7c22e into master Nov 29, 2025
5 checks passed
@inimaz inimaz deleted the inimaz-patch-4 branch November 29, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants