This repository was archived by the owner on May 16, 2024. It is now read-only.
[ETFeeder] Speedup et_feeder and resolve uninitialized attrs values in ETFeederNode #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
changhai0109
force-pushed
the
changhai-speedup-etfeeder
branch
from
d8702fd to
801aa45
Compare
Contributor
|
This is a useful fix. ET feeder is being used by other downstream use cases and we need (a) unit test (b) before and after improvements. Thanks! |
srinivas212
reviewed
Nov 22, 2023
Contributor
There was a problem hiding this comment.
Can we separate the specific changes with this PR and move the formatting changes to another PR?
Author
There was a problem hiding this comment.
These format changes are not meant to be there, instead come from the auto fomatter of my IDE.
I cleaned these format changes, also cleaned the commit history. Now it only contains the necessary changes there.
srinivas212
reviewed
Nov 22, 2023
changhai0109
force-pushed
the
changhai-speedup-etfeeder
branch
2 times, most recently
from
9d111ec to
3855955
Compare
Author
|
Moved the commit of changing et_converter output this PR, will submit another one later. |
changhai0109
force-pushed
the
changhai-speedup-etfeeder
branch
from
3855955 to
a0bd378
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.