Skip to content
This repository was archived by the owner on May 16, 2024. It is now read-only.

Conversation

@ZhenruiLi
Copy link

Converting from ASTRA-sim-1.0 Text Files to Chakra format triggers the following attribute error.
20231128001401
This PR fixes the error.

@ZhenruiLi ZhenruiLi requested a review from a team as a code owner November 27, 2023 16:17
@github-actions
Copy link

MLCommons CLA bot:
Thank you very much for your submission, we really appreciate it. Before we can accept your contribution, we ask that you sign the MLCommons CLA (Apache 2). Please use this [Google form] (https://forms.gle/Ew1KkBVpyeJDuRw67) to initiate authorization. If you are from an MLCommons member organization, we will request that you be added to the CLA. If you are not from a member organization, we will email you a CLA to sign. For any questions, please contact support@mlcommons.org.
0 out of 1 committers have signed the MLCommons CLA.
@anchorrrr
You can retrigger this bot by commenting recheck in this Pull Request

@ZhenruiLi ZhenruiLi closed this Nov 27, 2023
@TaekyungHeo
Copy link
Contributor

Hello @anchorrrr,

We appreciate your contribution. It seems that the text2chakra Converter is outdated. The schema has been updated to v0.0.4, and you can find the detailed description in the Chakra Schema v0.0.4 Release Notes. We need to update the text2chakra converter to reflect these changes, specifically by replacing the 'parent' field with the 'data_dep' field.

@ZhenruiLi ZhenruiLi reopened this Nov 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2023
@srinivas212
Copy link
Contributor

@anchorrrr it would be great if you can update this PR given the feedback / pointers from @TaekyungHeo. Please let us know if you have additional questions. Thanks!

@changhai0109
Copy link

Hello, @anchorrrr

Wish you have a good day! I might covered this in #78 by changing parents to data_deps, and also fixed some other bugs in the text converter. Could you please check out the PR and leave any comments if you like? Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants