Skip to content

add collective dependencies as data_deps #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
theodorbadea wants to merge 3 commits into from
Closed

add collective dependencies as data_deps #191

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d218c3c
add collective dependencies as data_deps
theodorbadea Apr 3, 2025
d0f259a
fix lint error
theodorbadea Apr 3, 2025
89d8266
remove redundant check
theodorbadea Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/converter/pytorch_converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,13 +433,19 @@ def convert_ctrl_dep_to_data_dep(
stack: List[ChakraNode] = [chakra_node]
last_visited_non_gpu: Optional[ChakraNode] = None
last_visited_any: Optional[ChakraNode] = None

pg_name_to_nccl_ops: Dict[str, List[int]] = {}
while stack:
current_node = stack.pop()
if current_node.id in visited:
continue
visited.add(current_node.id)

if current_node.type == COMM_COLL_NODE:
pg_name = json_node_map[current_node.id].pg_name
if pg_name in pg_name_to_nccl_ops:
current_node.data_deps.append(pg_name_to_nccl_ops[pg_name][-1])
pg_name_to_nccl_ops[pg_name].append(current_node.id)
else:
pg_name_to_nccl_ops[pg_name] = [current_node.id]

visited.add(current_node.id)
json_node = json_node_map.get(current_node.id)
if not json_node:
continue
Expand Down
Loading