This repository was archived by the owner on Apr 19, 2023. It is now read-only.
[wip] add pieces for ESLint (issue #220) #296
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suyashkumar
approved these changes
May 30, 2018
Collaborator
suyashkumar
left a comment
suyashkumar
left a comment
There was a problem hiding this comment.
Awesome thanks for going this! We may want to prevent this from running in the build until the codebase is pulled up to par with the AirBnB style.
| @@ -0,0 +1,4 @@ | |||
| module.exports = { | |||
| "parser": "babel-eslint", | |||
| "extends": "google" | |||
Collaborator
There was a problem hiding this comment.
Let's go with AirBnB style...it's the most popular and easy on the eyes :).
Collaborator
|
Also, I think it would be good to add this same style linter to the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@suyashkumar I'd like to get this linter going to make sure that I'm adhering to some sort of standard. I trolled the open issues and found this one so I added the ESLint package, but I saw that there are several popular styles (Google, AirBnB, etc.), so I'll let you choose, and then I will follow. I arbitrarily set this up with the Google style as the configured default, but I'm 100% agnostic to this.