-
Notifications
You must be signed in to change notification settings - Fork 33
Fix/windows support #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/windows support #455
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@PhilipWee I'm feel a little resistant to adding the various dependencies to fill in for bash basics. Have you tried using windows subsystem for linux, or git bash? (git bash should be sufficient - it has |
Im okay to remove the windows specific changes, are the other changes ( like the docker migra fallback for tests) okay? Although I don't mind some clarification on why youre against it since they are only dev dependencies and shouldnt be included in the final bundle, if its just for cleaniness thats fine for me |
|
Hi @mmkal sorry bumping this because I'm quite keen to merge other improvements I have in the pipeline How about I do the following:
|
|
Hey, sorry I haven't had a chance to try this out. The docs look good but I worry there's a risk that with these changes things won't work consistently on my machine anymore. I don't think that's a huge risk for rimraf et al but it's possible. I'd prefer to not have the docker fallback stuff in migra tests either tbh. I think it's better to have one way of doing things that works consistently. Worth noting, I made a change recently to pip install exact versions of migra and its dependencies because a deprecation warning was messing with stdout which affected tests in CI. So the original problem you saw, if it was similar, might be solvable in the same way? #452 In the meantime why not create a branch of this branch so you can open a PR with a clean diff which works for you locally? |
|
Sure thing, I'm okay with that - I'll update the multiple exclude support PR without my compatibility fixes then Probably on the weekend though I'm kinda busy now too 😅 |
I had some trouble setting up and running the repo on windows, so I've added the following
contributing.mdfilesmigrais not available on path locally (Because migra doesn't work with python 3.12 which is the version installed on my system)I'm not quite sure how you feel about these changes (For example the docker container tests), but I'm happy to cherry pick and keep/remove whatever you think is best
Regardless I just set this up so that I can continue running the other tests and make my other fixes to this branch, in a way