-
Notifications
You must be signed in to change notification settings - Fork 782
Add OSC8 hyperlink support #1360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Per the specification described in https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda, add hyperlink support to mosh. Closes mobile-shell#1245
|
For us to consider merging this it needs to have test coverage. |
|
That's a fair cop. I didn't immediately find the test suite but now I have I will take a crack at it. |
|
Good catch. I'm rethinking the way the params are parsed and they should all be technically preserved, not just id. |
Just store the params unparsed since we don't explicitly need the id.
|
PTAL, there's a test now and I reworked the param parsing. |
|
Please let me know if there's any further issue. I'd like to take a stab at adding OSC7 support as well since it seems straightforward compared to this, but would like to see this merged first. |
|
I did a quick test and review and it seems to work as advertised, but I'll do some more real-world testing over the next few weeks |


Per the specification described in https://gist.github.com/egmontkob/eb114294efbcd5adb1944c9f3cb5feda, add hyperlink support to mosh.
Closes #1245