-
Notifications
You must be signed in to change notification settings - Fork 307
feat: support gpu & support invoke speechscore via code #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @dujl, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces GPU support for various scoring models and improves path handling to make invoking speechscore from code more robust. The changes for DISTILL_MOS and DNSMOS correctly add GPU support and fix model path resolution. The path resolution has also been improved for NISQA.
My review focuses on ensuring the GPU support is consistently applied. I've found one place where GPU support was missed. I also have a minor suggestion regarding file formatting conventions.
speechscore/scores/nisqa/nisqa.py
Outdated
| self.intrusive = False | ||
| self.score_rate = 48000 | ||
| self.model = load_nisqa_model("scores/nisqa/weights/nisqa.tar", device='cpu') | ||
| self.model = load_nisqa_model(os.path.join(os.path.dirname(os.path.abspath(__file__)), "weights/nisqa.tar"), device='cpu') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This model is hardcoded to use the CPU, which is inconsistent with the goal of this pull request to add GPU support. You should dynamically select the device (GPU if available, otherwise CPU), similar to the implementation for DISTILL_MOS.
You will need to add import torch at the top of the file to use torch.device.
| self.model = load_nisqa_model(os.path.join(os.path.dirname(os.path.abspath(__file__)), "weights/nisqa.tar"), device='cpu') | |
| device = torch.device("cuda" if torch.cuda.is_available() else "cpu") | |
| self.model = load_nisqa_model(os.path.join(os.path.dirname(os.path.abspath(__file__)), "weights/nisqa.tar"), device=device) |
| score = self.model(torch.from_numpy(np.expand_dims(audios[0], axis=0)).float()) | ||
| score = self.model(torch.from_numpy(np.expand_dims(audios[0], axis=0)).float().to(self.device)) | ||
| score_np = score.detach().cpu().numpy() | ||
| return score_np[0][0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Accelerate distill_mos and dnsmos speech scoring using GPU