Skip to content

Conversation

@WarmCongee
Copy link

The repository did not specify the version of the soxr package in the past. ClearerVoice was last updated before August 2025, while the soxr package released version 1.0 in September 2025. Installing it directly would result in installation errors and compilation of soxr would fail. Soxr is a dependency of multiple packages in the requirements.txt. Here, soxr is specified as the last version before version 1.0, 0.5.0.post1

The repository did not specify the version of the soxr package in the past. ClearerVoice was last updated before August 2025, while the soxr package released version 1.0 in September 2025. Installing it directly would result in installation errors and compilation of soxr would fail. Soxr is a dependency of multiple packages in the requirements.txt. Here, soxr is specified as the last version before version 1.0, 0.5.0.post1
@gemini-code-assist
Copy link

Summary of Changes

Hello @WarmCongee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical dependency issue within the project's environment setup. By specifying an older, compatible version for the soxr package, it prevents installation and compilation failures that arise from a version mismatch with the recently released soxr v1.0. This ensures a stable and reproducible development environment.

Highlights

  • Dependency Version Pinning: The soxr package has been explicitly pinned to version 0.5.0.post1 in the requirements.txt file.
  • Installation Bug Fix: This change resolves installation and compilation errors that occurred when using soxr version 1.0, which was released after the ClearerVoice project's last update.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a build failure by pinning the soxr dependency to a specific version, preventing an incompatible version from being installed. While this is a good immediate fix, I've also raised a more general concern about dependency management in requirements.txt. Many packages are not pinned to specific versions, which creates a risk of future build breakages. I've recommended pinning all dependencies to ensure reproducible builds and improve the overall stability of the project's environment.

yamlargparse==1.31.1
torchinfo==1.8.0
tqdm==4.67.0
soxr==0.5.0.post1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Pinning the soxr version is a great step towards ensuring build stability. However, I've noticed that many other packages in this file (e.g., pyyaml, pysptk, pymcd) are not pinned to a specific version. This leaves the project vulnerable to future build failures if any of those packages release breaking changes, similar to the issue this PR is fixing. For reproducible and stable environments, it's a strong best practice to pin all dependencies to specific versions. Consider using a tool like pip-tools to manage and generate a fully pinned requirements.txt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant