Propose to improve p02
#201
Conversation
| @@ -1,5 +1,3 @@ | |||
| from memory import UnsafePointer | |||
There was a problem hiding this comment.
We didn't need to import memory.UnsafePointer at the first puzzle, thus isn't it built-in?
There was a problem hiding this comment.
Pull request overview
This PR aims to clean up unused imports in puzzle 2 files and fix a documentation link. The changes remove imports that are not directly used in the respective files and update a reference link to be more specific.
Changes:
- Removed unused imports (
UnsafePointer,block_dim,block_idx) from solution and problem files - Removed starter code hint in the problem file and adjusted the comment
- Fixed documentation link to point specifically to
introduction_layout_tensor.md
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| solutions/p02/p02.mojo | Removes unused imports while keeping thread_idx which is used in the solution |
| problems/p02/p02.mojo | Removes all imports and starter hint, making the problem harder |
| book/src/puzzle_02/puzzle_02.md | Fixes documentation link to be more specific |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tive link in the documentation.
tolgacangoz
force-pushed
the
improve-p02
branch
from
922885b to
fe9a86d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 participant
Thanks a lot for this implementation-based learning environment!
Hi @dunnoconnor! FYI: Puzzle 2's video isn't included in the playlist: https://www.youtube.com/playlist?list=PLh0S94-sJw_5yv_s--TW0Asi6liIy0NGz
This pull request makes minor improvements to documentation and code clarity by fixing a broken link and removing unused imports from two files.
Documentation update:
book/src/puzzle_02/puzzle_02.mdto correctly point to theintroduction_layout_tensor.mdfile.Code cleanup:
UnsafePointer,block_dim,block_idx) fromproblems/p02/p02.mojoto clean up the code.UnsafePointer,block_dim,block_idx) fromsolutions/p02/p02.mojofor consistency and clarity.