Fix Ditto TV inheritance processing by setting docid #385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug in the Ditto snippet where TV (Template Variable) inheritance processing was failing because the docid field wasn't being passed to the tvProcessor() function. This caused Image TVs and other inherited values to not display correctly.
Changes:
- Added
docidfield assignment before each call totvProcessor()in theappendTV()method
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
appendTV()が@INHERITやデフォルト値を各ドキュメント文脈で正しく解決するためのdocid情報を渡しておらず、Image等のTV出力が表示されない問題を解消するための修正です。Description
assets/snippets/ditto/classes/ditto.class.inc.phpのappendTV()内で、取得したTV行やデフォルト処理の各分岐の前に$row['docid']を該当するcontentid/$idで設定するように3箇所挿入しました（例:$row['docid'] = $row['contentid'];/$row['docid'] = $id;）。Testing
Codex Task