Fix file browser root label for resource types #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the MCPUK File Browser where the root folder label in the tree view always displayed "Images" regardless of which resource type was selected from the dropdown menu. The fix adds a helper function to dynamically determine the correct label based on the active resource type.
Changes:
- Added
getResourceTypeLabelfunction to map resource type values ('files', 'media', 'images') to their display labels - Updated the root node creation to use the dynamic label instead of the hardcoded 'images' value
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Imagesのまま表示されていたため、選択中のリソース種別に応じて正しいラベルを表示するようにするための修正です。Description
manager/media/browser/mcpuk/frmfolders.htmlのRender処理でルートラベルをハードコードの'images'からgetResourceTypeLabel(oConnector.ResourceType)に置き換え、getResourceTypeLabelヘルパーを追加してfiles/media/imagesに対応する表示名を返すようにしました。Testing
Codex Task