762_duplicate_literature_references #776
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadronCollider
requested changes
Dec 7, 2025
Comment on lines
+59
to
+62
|
|
||
| if not self.checking_duplicate_sources(): | ||
| return answer(False, 'В списке используемых источников есть дублирующиеся источники.') | ||
|
|
Collaborator
There was a problem hiding this comment.
Фидбек критерия должен быть составным:
- фидбек по основной проверке (та, что уже есть)
- фидбек по дубликатам
- должен содержать подробности: какие источники дублируются (их номера и формулировки)
- Если по проверке 2) всё ок, балл за критерий = балл за первую проверку
- Если по проверка 2) не ок - балл за критерий 0
Comment on lines
+132
to
+137
| def checking_duplicate_sources(self): | ||
| for source in self.literature_reference_text: | ||
| if self.literature_reference_text.count(source) >= 2: | ||
| return False | ||
| return True | ||
|
|
Collaborator
There was a problem hiding this comment.
Подобной проверки недостаточно
- для пользователя / фидбека нужно подробное описание дубликатов (их номера и формулировки)
- сделайте проверку регистронезависимой
- для подсчета кол-ва пригодится
from collections import Counter- это эффективнее, чем dict+for+count
Collaborator
|
Подтяните изменения из dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#762