RUST-2312 Implement default trait for cstring #625
Conversation
kevinAlbs
changed the title
isabelatkinson
left a comment
isabelatkinson
left a comment
There was a problem hiding this comment.
Thanks for the PR! While we're here, would you mind adding a Default impl for the owned CString type as well? It can also construct an empty string.
Yes it is done |
abr-egn
requested review from
abr-egn
and removed request for
isabelatkinson
|
(Isabel's on vacation, so I'm keeping this moving) Thanks again! Once the tests pass I'll merge this in. |
src/raw/cstr.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl Default for CString { |
There was a problem hiding this comment.
Looks like clippy wants this to be derived rather than manually written - once that's done this will be good to merge :)
There was a problem hiding this comment.
I have fixed this and added the new method based on @tyilo's comment
|
I think that |
This has also been added based on your changes |
norskovsen
force-pushed
the
add-default-trait-for-cstring
branch
from
bd471d5 to
3398a48
Compare
norskovsen
force-pushed
the
add-default-trait-for-cstring
branch
from
3398a48 to
dfc2620
Compare
abr-egn
left a comment
abr-egn
left a comment
There was a problem hiding this comment.
Thanks again, in particular for patience with the rounds of revisions!
5 participants
No description provided.