-
Notifications
You must be signed in to change notification settings - Fork 213
PHPC-2654: Update to libmongoc 2.2.1 #1900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,3 +12,5 @@ AC_SUBST(libmongoc_VERSION_MAJOR) | |
| AC_SUBST(libmongoc_VERSION_MINOR) | ||
| AC_SUBST(libmongoc_VERSION_PATCH) | ||
| AC_SUBST(libmongoc_VERSION_PRERELEASE) | ||
| AC_SUBST(MONGOC_CXX_COMPILER_ID, "") | ||
| AC_SUBST(MONGOC_CXX_COMPILER_VERSION, "") | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Noted these are the defaults in libmongoc: https://github.com/mongodb/mongo-c-driver/blob/2.2.1/src/libmongoc/CMakeLists.txt#L754-L755 It doesn't seem ideal that libmongoc pollutes the handshake string with cc: @kevinAlbs There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Suggest using an empty string instead of "Unknown" to signal "did not check". Filed CDRIVER-6175 to omit "CXX=" entirely if Quoting mongodb/mongo-c-driver#2114:
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point, I had copied this over from the defaults. I've changed it to an empty string. |
||
Uh oh!
There was an error while loading. Please reload this page.