Skip to content

Conversation

@monzchan
Copy link
Owner

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

Complete assignment 2 with new coding learned from class

What did you learn from the changes you have made?

using readline(), for loop, numpy

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

using readlines() withoout the for loop
instead of using the if statement for checkzeros(x), simply putting return checkzeros(x) could have the same result

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

Yes. Issues like how to use readlines and accessing specific items in numpy array. I attended the office hour and ask the TA. They have helped alot!

How were these changes tested?

using python, verify with suggested answer

A reference to a related issue in your repository (if applicable)

@mentions of the person or team responsible for reviewing proposed changes (At least 2 people)

Checklist

  • [V] I can confirm that my changes are working as intended

Copy link

@dwz92 dwz92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve your merge conflict. Next time choose better branch name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants