-
Notifications
You must be signed in to change notification settings - Fork 3
cdn.moq.dev #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdn.moq.dev #71
Conversation
WalkthroughThis pull request removes most Terraform infrastructure-as-code configuration from the infra directory, including service account setup, DNS and certificate management, load balancer configuration, and relay and pub deployment templates. Configuration files are deleted or emptied, and the infra directory is added to the Docker build context. Environment variables and documentation are updated to reference cdn.moq.dev instead of relay.moq.dev. Documentation examples are updated to reflect changes to the module location and hosting provider references. Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/pages/blog/first-cdn.mdx (1)
93-93: Add comma after "too" for clarity.The phrase "You too can run..." introduces an abrupt change of thought and would benefit from emphasis.
- There's even a [terraform module](https://github.com/kixelated/moq/blob/main/cdn/relay.tf) that powers `cdn.moq.dev`. You too can run your own "global" CDN with 3 nodes and pay ~GCP~ Linode a boatload of money for the privilege. + There's even a [terraform module](https://github.com/kixelated/moq/blob/main/cdn/relay.tf) that powers `cdn.moq.dev`. You, too, can run your own "global" CDN with 3 nodes and pay ~GCP~ Linode a boatload of money for the privilege.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (18)
.dockerignore(0 hunks).env.production(1 hunks)README.md(1 hunks)infra/.gitignore(0 hunks)infra/.terraform.lock.hcl(0 hunks)infra/deploy.tf(0 hunks)infra/domain.tf(0 hunks)infra/iam.tf(0 hunks)infra/input.tf(0 hunks)infra/internal.tf(0 hunks)infra/main.tf(0 hunks)infra/output.tf(0 hunks)infra/pub.tf(0 hunks)infra/pub.yml.tpl(0 hunks)infra/relay-lb.tf(0 hunks)infra/relay.tf(0 hunks)infra/relay.yml.tpl(0 hunks)src/pages/blog/first-cdn.mdx(1 hunks)
💤 Files with no reviewable changes (15)
- infra/pub.yml.tpl
- infra/domain.tf
- infra/output.tf
- infra/relay.tf
- infra/.gitignore
- .dockerignore
- infra/iam.tf
- infra/internal.tf
- infra/pub.tf
- infra/input.tf
- infra/main.tf
- infra/relay.yml.tpl
- infra/relay-lb.tf
- infra/.terraform.lock.hcl
- infra/deploy.tf
🧰 Additional context used
🪛 dotenv-linter (4.0.0)
.env.production
[warning] 1-1: [QuoteCharacter] The value has quote characters (', ")
(QuoteCharacter)
🪛 LanguageTool
src/pages/blog/first-cdn.mdx
[style] ~93-~93: Consider setting off ‘too’ with commas if you want to emphasize an abrupt change of thought.
Context: ...dn/relay.tf) that powers cdn.moq.dev. You too can run your own "global" CDN with 3 no...
(MISSING_COMMA_WITH_TOO)
🔇 Additional comments (3)
.env.production (1)
1-1: Update aligns with CDN migration.The URL change from
relay.moq.devtocdn.moq.devis consistent with the PR's infrastructure shift and matches the updates in other files (README.md and first-cdn.mdx). The dotenv-linter QuoteCharacter warning is a false positive; double quotes are standard for environment files.README.md (1)
8-8: Verify the tooling reference change from moq-rs to moq.The README now references
moqinstead ofmoq-rs. Please confirm this reflects the intended canonical name for the project and that this isn't an unintended removal of specificity (moq-rs being the Rust implementation).Verify that
moqis the correct canonical reference and thatmoq-rsis not being actively maintained or is intentionally being de-emphasized.src/pages/blog/first-cdn.mdx (1)
93-94: No action needed. Both the Terraform module path (cdn/relay.tf) and the hosting provider change (from GCP to Linode) are accurate and correctly reflected in the moq repository.
No description provided.