-
Notifications
You must be signed in to change notification settings - Fork 84
M menu tree #239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
byersa
wants to merge
40
commits into
moqui:master
Choose a base branch
from
byersa:m-menu-tree
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
M menu tree #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use h() function to replace createEl()
Fixed Template Error: expression 'urlPathRoot' was null or not found
adding the fix to the addRoute call inside the loadComponent return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did a lot of study and ended up replacing the entire left drawer menu (ie. m-menu-nav-item) with a new component, m-menu-tree, which is almost a direct use of Quasar's qTree component. It is much simpler. I did not bother to transition the "savedFinds" functionality because it would be very difficult to find a test case. Gemini concurred that I would have to create a special project to test it. So the bottom line is that since it would probably never be used, we would be better off just leaving it out.
I would like to do more testing, but I would like to do it in conjunction with working with Taher in moving to Java 21.