MAF-19069: feat(deploy): add moai-inference-preset chart #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new Helm chart moai-inference-preset for the Moreh Inference Framework, along with supporting infrastructure for converting InferenceServiceTemplate files to Helm templates and automating production deployments.
Key Changes:
- Introduces a Python utility script to automate the conversion of InferenceServiceTemplate YAML files to Helm-compatible templates
- Adds a complete Helm chart structure with dependencies on Bitnami's common chart library
- Implements a GitHub Actions workflow for automated production releases triggered by semantic version tags
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| hack/change_isvctmpl_to_helm.py | Python utility to convert InferenceServiceTemplate files to Helm templates by escaping Go template syntax and injecting standard labels |
| deploy/helm/moai-inference-preset/Chart.yaml | Helm chart metadata defining the moai-inference-preset application chart with Bitnami common dependency |
| deploy/helm/moai-inference-preset/values.yaml | Default configuration values for name overrides and common labels |
| deploy/helm/moai-inference-preset/Chart.lock | Dependency lock file specifying the exact version of the common chart |
| deploy/helm/moai-inference-preset/charts/common-2.31.4.tgz | Vendored Bitnami common chart library (binary file) |
| deploy/helm/moai-inference-preset/.helmignore | Standard Helm ignore patterns for VCS and IDE files |
| deploy/helm/moai-inference-preset/README.md | Auto-generated documentation describing the chart and its dependencies |
| deploy/helm/moai-inference-preset/README.md.gotmpl | Template for generating the README with helm-docs |
| .github/workflows/cd-prod-preset.yaml | CI/CD workflow to release the preset chart on semantic version tags with preset/ prefix |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| # 4. --to <file|dir> | ||
| # 5. If `--to <dir>` is given, output files are named as `<original_name>.helm.yaml` | ||
|
|
||
| # Generated by gemini |
There was a problem hiding this comment.
The "Generated by gemini" comment should be replaced with proper authorship or tool attribution. AI-generated code comments should typically indicate the specific tool/model used and include a verification note, or be removed in favor of standard documentation.
Suggested change
| # Generated by gemini | |
| # Originally generated with Google Gemini (AI model); reviewed and maintained by project contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.