-
Notifications
You must be signed in to change notification settings - Fork 69
make feeToken slot cold in revm #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request updates the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
prover/Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (7)
contracts/src/deploy-config/holesky.tscontracts/src/deploy-config/hoodi.tscontracts/src/deploy-config/l1.tscontracts/src/deploy-config/qanetl1.tscontracts/src/deploy-config/sepolia.tscontracts/src/deploy-config/testnetl1.tsprover/bin/client/elf/riscv32im-succinct-zkvm-elf
🧰 Additional context used
🪛 Gitleaks (8.30.0)
contracts/src/deploy-config/sepolia.ts
[high] 21-21: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
contracts/src/deploy-config/l1.ts
[high] 20-20: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
contracts/src/deploy-config/qanetl1.ts
[high] 17-17: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
contracts/src/deploy-config/hoodi.ts
[high] 20-20: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: build
- GitHub Check: test
- GitHub Check: Analyze (go)
- GitHub Check: Analyze (rust)
🔇 Additional comments (7)
contracts/src/deploy-config/sepolia.ts (2)
21-21: Static analysis warning is a false positive.The Gitleaks warning about "Generic API Key" can be safely ignored. The
programVkeyis a public zero-knowledge proof verification key used in blockchain systems, not a secret credential.
21-21: Ensure the new programVkey is tested and documented across all deployment environments.The new key
0x00ad538a51c761c06f5075d11f3ee64d5d00c272a741ccf098e1d9f062fee13dhas been consistently rotated across all deployment configurations (sepolia, holesky, l1, testnetl1, qanetl1, and hoodi). Verify that:
- The new key has been properly tested with off-chain provers
- All verifier contracts can accept proofs generated with this key
- The transition is coordinated to prevent verification failures across environments
Document the reason for this key rotation (e.g., program upgrade, security update) in the PR description.
contracts/src/deploy-config/hoodi.ts (1)
20-20: Consistent verification key update.The
programVkeyupdate aligns with the coordinated changes across all deployment environments. The static analysis warning is a false positive (public verification key, not a secret).contracts/src/deploy-config/qanetl1.ts (1)
17-17: Consistent verification key update.The
programVkeyupdate aligns with the coordinated changes across all deployment environments. The static analysis warning is a false positive (public verification key, not a secret).contracts/src/deploy-config/testnetl1.ts (1)
16-16: Consistent verification key update.The
programVkeyupdate aligns with the coordinated changes across all deployment environments.contracts/src/deploy-config/l1.ts (1)
20-20: Consistent verification key update.The
programVkeyupdate aligns with the coordinated changes across all deployment environments. The static analysis warning is a false positive (public verification key, not a secret).contracts/src/deploy-config/holesky.ts (1)
17-17: Consistent verification key update.The
programVkeyupdate aligns with the coordinated changes across all deployment environments.
| * ---to---legacy property | ||
| */ | ||
| programVkey: '0x0044eed79d39a90e842c5f5e599d019cbe63c1719300f1366f9dc4d3729f7810', | ||
| programVkey: '0x00ad538a51c761c06f5075d11f3ee64d5d00c272a741ccf098e1d9f062fee13d', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title doesn't match the actual changes.
The PR title mentions "make feeToken slot cold in revm" but the changes update programVkey across deployment configs. This inconsistency suggests either the wrong files were included or the PR title is incorrect.
🧰 Tools
🪛 Gitleaks (8.30.0)
[high] 21-21: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
🤖 Prompt for AI Agents
contracts/src/deploy-config/sepolia.ts around line 21: the PR title refers to
"make feeToken slot cold in revm" but the diff changes programVkey in deployment
configs, creating an inconsistency; either update the PR title/description to
accurately reflect that programVkey values were changed across configs, or
revert/remove the unintended programVkey edits from this commit so the PR only
contains the feeToken revm change; confirm the correct programVkey for sepolia
before committing, amend the commit message or create a new commit with the
intended changes, and run git add/commit --amend (or git restore) and update the
PR accordingly.
make feeToken slot cold in revm (#840)
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.