Skip to content

Conversation

@curryxbo
Copy link
Contributor

@curryxbo curryxbo commented Dec 25, 2025

Summary by CodeRabbit

  • Chores
    • Added support for Hoodi environment deployment targets for the token-price-oracle service, enabling new build and execution workflows for this service in the specified environment.

✏️ Tip: You can customize this high-level summary in your review settings.

@curryxbo curryxbo requested a review from a team as a code owner December 25, 2025 06:16
@curryxbo curryxbo requested review from secmgt and removed request for a team December 25, 2025 06:16
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 25, 2025

📝 Walkthrough

Walkthrough

This PR adds new Makefile targets to MakefileEks.mk for building and starting a token-price-oracle service in the Hoodi environment. The targets compile the binary, copy it to the dist directory, fetch a secret-manager-wrapper archive from testnet Hoodi S3 storage, and extract it for runtime use.

Changes

Cohort / File(s) Summary
Hoodi token-price-oracle targets
MakefileEks.mk
Adds build and start Makefile targets (build-bk-prod-morph-prod-testnet-to-morph-token-price-oracle-hoodi and start-bk-prod-morph-prod-testnet-to-morph-token-price-oracle-hoodi) with steps for compilation, binary distribution, and secret-manager-wrapper setup from Hoodi S3. Note: targets appear duplicated in the file with identical implementation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • Web3Jumb0
  • MarvelFisher

Poem

🐰 A makefile grows with magic spells,
Token oracles in Hoodi shells,
Build and fetch from S3 skies,
Secrets wrapped in neat supplies!

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Update MakefileEks.mk' is vague and generic, using non-descriptive language that doesn't convey the specific changes being made to the Makefile. Provide a more descriptive title that specifically mentions the key changes, such as 'Add Hoodi environment targets for token-price-oracle' or 'Add token-price-oracle Hoodi build and start targets'.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch update-eks

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@curryxbo curryxbo changed the title Update eks Update MakefileEks.mk Dec 25, 2025
@curryxbo curryxbo merged commit 71d75d9 into main Dec 25, 2025
7 checks passed
@curryxbo curryxbo deleted the update-eks branch December 25, 2025 06:40
FletcherMan added a commit that referenced this pull request Dec 25, 2025
@coderabbitai coderabbitai bot mentioned this pull request Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants