Big refactor #41
Open
Big refactor #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworking the approach to preferences to accommodate user-configurable settings. Started to build out the settings UI. Misc bug fixes User list embeds
Mostly eliminated the MorphoDataFeed type that had a bunch of hacky stuff, reduced boilerplate, made it more extensible, and improved thread/filter handling. Seem to have introduced another cursor bug, need to investigate.
…e api client to something more like the Agent model in the official client. Think it ends up simplifying the application code a fair bit going forward.
It was running into a bug in Voyager which seemingly didn't have a fix, only open issues. Likely also helps the Parecelize/Parcelable nonsense I was dealing with before. Do need to make sure of state saving on mobile, however.
App starts up again (on desktop at least). Now to just make sure events are being dispatched correctly.
…some unforeseen issues with the clean up results. Stuff stopped compiling for no clear reason. WTF, Kotlin.
Merging this to main, then will rebase my dev bran
Also discovered that Bluesky reworked some of the label stuff again, bringing "defaultSetting" and the "Visibility" enum in line with eachother and adding a new "Severity" value, which was causing some errors.
Noting that the paging thing is loading very few things at once and making a lot of requests. I think we're filtering out too many things from the feed somehow?
…it, but still being funny.
…plicated a bunch for each reply. Definitely need to fix the parenting thing, that's definitely where the problem is.
More work on settings.
…cesUnion as a test. Seems to have worked, now needs to be implemented for the other atproto type unions in here. Ultimately we should be able to generate most of the extra boilerplate with Lexsync alongside the lexicons.
…alizer workaround is no longer needed and we can delete it and A LOT of boilerplate code.
…alizer workaround is no longer needed and we can delete it and A LOT of boilerplate code.
- Various sections built out - added a library to access build config variables on any platform - Made most of a BskyLabelService display fragment, for the labeler view that doesn't exist quite yet - Added a couple new Morpho-specific settings to the settings class - Various other cleanup and fixes
- Also found a couple of new keys in the visibility settings/default settings for content labels.
This was
linked to
issues
Sep 22, 2024
Member
Author
|
Ok, think I'm ready for the merge. Big refactor is more or less done, making progress on settings now. Big remaining things are logging out/switching users, more settings, profile editing, |
…s for code generation. see lines 89 and subsequent in Types.kt in this commit.
…s for code generation. see lines 89 and subsequent in Types.kt in this commit.
…s for code generation. see lines 89 and subsequent in Types.kt in this commit.
Also, added first bit of support for longer posts and profile descriptions bridged from Mastodon.
Much happier with where I am on this now, doesn't feel *buggy* like it did for a good while after the refactor. - Seem to have eliminated most or all of the duplicates without just filtering out almost everything randomly sometimes, especially duplicates across pages of data. - Still some ways to be more efficient, make fewer copies, go over the list fewer times (idk how well the Kotlin compiler optimizes this stuff) - Threads are fairly reliably collected together, but still some times where you get chunks of the same thread that aren't spliced correctly. - Got rid of an error on pager invalidation/refresh, so refresh seems to work better.
- current showstopper android bug, crash due to nav drawer or modal bottom sheet when switching to notification screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once the refactor is done, going to do a big merge.