ui: Only show TreeHerder link if enabled (bug 2004162) #788
Conversation
|
View this pull request in Lando to land it once approved. |
shtrom
force-pushed
the
bug2004162/treeherder-link-repo
branch
from
ba9d9f0 to
38ab7a9
Compare
zzzeid
left a comment
zzzeid
left a comment
There was a problem hiding this comment.
I think the treeherder name can be gleaned from the hg repo's push path, so not sure we need an explicit field for this? I don't think there are any exceptions to this rule at this time.
zzzeid
left a comment
zzzeid
left a comment
There was a problem hiding this comment.
Note that the migration needs to be regenerated as it is now outdated.
Approved with a nit, I think we could get the treeherder repo name from the repo name itself in most if not all cases.
Yes, that's how we have historically been doing it, but as we are getting more repos in Git, with new names, this becomes less straightforward (particularly for those repos that don't actually have Treeherder support). Making the name explicit here allows us to avoid the uncertainty. |
Ah! But we can use that information for data migration, at least! |
Ok, I did just that (and renumbered the migration)! |
shtrom
dismissed
zzzeid’s stale review
Probably worth another look for the data migration.
shtrom
changed the title
shtrom
changed the title
|
Note: there is a small typo in the PR description ("changeoc"). |
|
This conflicts with main. Rebasing. |
shtrom
force-pushed
the
bug2004162/treeherder-link-repo
branch
from
b54ec02 to
d5f6332
Compare
|
Needs squashing... https://lando.moz.tools/landings/24316/ |
shtrom
force-pushed
the
bug2004162/treeherder-link-repo
branch
from
d5f6332 to
982dc1b
Compare
This commit introduces a new `Repo.treeherder_name` field. If this field is not empty, Treeherder links are shown. In addition, the `repo` QueryString parameter is added to those links, to match the `treeherder_name`. This allows lando to point to results for commits which are not on `autoland` (the Treeherder default). Two data migration steps are included in this change for pre-existing repos: * use HgMO url to find the treeherder name; * use the git default_branch for `firefox-` Git repos. --- * Repo: add treeherder_name field (bug 2004162) * jinja2: update type hints (Bug 1986844) * jinja2: use Repo.treeherder_name in treeherder_link (bug 2004162) * ui: Only show TreeHerder link if enabled (bug 2004162) Pull request: #788
|
Pull request closed by commit 1c56034 |
This commit introduces a new
Repo.treeherder_namefield. If this field is not empty, Treeherder links are shown.In addition, the
repoQueryString parameter is added to those links, to match thetreeherder_name. This allows lando to point to results for commits which are not onautoland(the Treeherder default).Two data migration steps are included in this change for pre-existing repos:
firefox-Git repos.