This repository was archived by the owner on Apr 3, 2019. It is now read-only.
fix(test): Avoid cross test pollution caused by mutating route objects. #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
shane-tomlinson
changed the title
Contributor
|
@shane-tomlinson 👍 👍 |
Contributor
|
We need this to progress! 👍 🍰 |
Contributor
|
@deeptibaghel we need to find why the reason why this patch is needed in hapi 17 and not in the current version that we are using |
Author
|
I'd be happy for @deeptibaghel to use this to progress in other areas of her PR, but it makes me nervous that I still do not understand the root cause of why this is needed with hapi 17 and not the previous version. It's almost like the |
vladikoff
changed the title
vladikoff
force-pushed
the
deepCopy-route-definition
branch
from
9661c3e to
769d17d
Compare
vladikoff
approved these changes
Jan 2, 2019
Contributor
|
We need this continue working on the Hapi updates. I ran some tests and things seemed in order 👍 |
Author
|
Hey, I forgot I had this PR open! Thanks @vladikoff! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help @deeptibaghel with #334. I added a ton of logging to Deepti's PR and Hapi and noticed that a route's
scopevalue was being updated for every test suite, the next test suite would then use the implicant values from the previous suite as it's scopes.This makes a copy of the route definition which is safe to mutate. Still a WIP because I would expect tests to be failing on master too, and I'm not sure why they aren't.
cc @rfk, @vladikoff, @deeptibaghel