feat(payments-next): Cancellation flow: Create page - Interstitial Offer #19859
+533
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizabeth-ilina
force-pushed
the
PAY-3371-create-page-interstitial-offer
branch
17 times, most recently
from
8bf0325 to
fb7e902
Compare
elizabeth-ilina
force-pushed
the
PAY-3371-create-page-interstitial-offer
branch
10 times, most recently
from
ec5a467 to
b54e666
Compare
elizabeth-ilina
commented
Jan 14, 2026
xlisachan
reviewed
Jan 21, 2026
apps/payments/next/app/[locale]/subscriptions/[subscriptionId]/offer/page.tsx
Outdated
Show resolved
Hide resolved
xlisachan
reviewed
Jan 21, 2026
apps/payments/next/app/[locale]/subscriptions/[subscriptionId]/offer/page.tsx
Outdated
Show resolved
Hide resolved
xlisachan
reviewed
Jan 21, 2026
apps/payments/next/app/[locale]/subscriptions/[subscriptionId]/offer/page.tsx
Outdated
Show resolved
Hide resolved
xlisachan
reviewed
Jan 21, 2026
apps/payments/next/app/[locale]/subscriptions/[subscriptionId]/offer/page.tsx
Outdated
Show resolved
Hide resolved
xlisachan
reviewed
Jan 21, 2026
apps/payments/next/app/[locale]/subscriptions/[subscriptionId]/offer/page.tsx
Outdated
Show resolved
Hide resolved
xlisachan
reviewed
Jan 21, 2026
apps/payments/next/app/[locale]/subscriptions/[subscriptionId]/offer/page.tsx
Outdated
Show resolved
Hide resolved
xlisachan
reviewed
Jan 21, 2026
apps/payments/next/app/[locale]/subscriptions/[subscriptionId]/offer/page.tsx
Outdated
Show resolved
Hide resolved
elizabeth-ilina
force-pushed
the
PAY-3371-create-page-interstitial-offer
branch
2 times, most recently
from
e898c7d to
35baab7
Compare
elizabeth-ilina
force-pushed
the
PAY-3371-create-page-interstitial-offer
branch
3 times, most recently
from
4fb6ac4 to
c162981
Compare
xlisachan
reviewed
Jan 22, 2026
apps/payments/next/app/[locale]/subscriptions/[subscriptionId]/offer/page.tsx
Outdated
Show resolved
Hide resolved
xlisachan
reviewed
Jan 22, 2026
| } | ||
|
|
||
| if (!interstitialOfferContent.isEligible || !interstitialOfferContent.pageContent) { | ||
| redirect(`/${locale}/subscriptions/${subscriptionId}/offer/error`); |
Contributor
There was a problem hiding this comment.
/${locale}/subscriptions/${subscriptionId}/offer/error
elizabeth-ilina
force-pushed
the
PAY-3371-create-page-interstitial-offer
branch
5 times, most recently
from
a1858cf to
2f5e37b
Compare
xlisachan
reviewed
Jan 23, 2026
libs/payments/ui/src/lib/nestapp/validators/GetInterstitialOfferContentActionResult.ts
Show resolved
Hide resolved
elizabeth-ilina
force-pushed
the
PAY-3371-create-page-interstitial-offer
branch
from
2f5e37b to
c6b045d
Compare
xlisachan
reviewed
Jan 23, 2026
| redirect(`/${locale}/subscriptions/${subscriptionId}/offer`); | ||
| } | ||
|
|
||
| const { reason, webIcon, productName} = interstitialOfferContent; |
Contributor
There was a problem hiding this comment.
const { webIcon, productName } = interstitialOfferContent;
const reason = interstitialOfferContent.reason ?? 'general_error';
if (webIcon && !productName) {
throw new Error('Missing productName for interstitial offer icon');
}
xlisachan
reviewed
Jan 23, 2026
|
|
||
| const { reason, webIcon, productName} = interstitialOfferContent; | ||
|
|
||
| if (!reason || !webIcon || !productName) { |
Contributor
There was a problem hiding this comment.
This can be removed with the suggestion above.
xlisachan
reviewed
Jan 23, 2026
| 'It looks like this subscription may no longer be active.' | ||
| ), | ||
| }; | ||
| case 'current_interval_not_found': |
Contributor
There was a problem hiding this comment.
Nit: We don't need to list all the cases - if it's not subscription_not_found, it will just use the default option
xlisachan
reviewed
Jan 23, 2026
| {webIcon && ( | ||
| <Image | ||
| src={webIcon} | ||
| alt={productName} |
Contributor
There was a problem hiding this comment.
alt={productName ?? ''} as productName can be optional
elizabeth-ilina
force-pushed
the
PAY-3371-create-page-interstitial-offer
branch
from
c6b045d to
ee820ad
Compare
xlisachan
reviewed
Jan 23, 2026
| > | ||
| {heading} | ||
| </h1> | ||
| <p className="w-full self-stretch leading-7 text-lg text-grey-900 text-center tablet:text-left"> |
Contributor
There was a problem hiding this comment.
tablet:text-left -> tablet:text-start perhaps?
In cases where the language direction is rtl, and not ltr.
Because: * We need a cancel interstitial offer page as part of the churn intervention epic. This commit: * Creates /[locale]/subscriptions/[subscription_id]/offer page Closes #PAY-3371
elizabeth-ilina
force-pushed
the
PAY-3371-create-page-interstitial-offer
branch
from
ee820ad to
c6d567f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: #PAY-3371
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.