feat(payments-next): Create Cancel churn page #19908
Open
+1,291
−105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlisachan
commented
Jan 21, 2026
| 'churn-error-page-message-discount-already-applied', | ||
| { productName }, | ||
| `This discount was applied to a ${productName} subscription for your account. If you still need help, please contact our Support team.` | ||
| `This discount was applied to a ${productName} subscription for your account. If you still need help, contact our Support team.` |
Contributor
Author
There was a problem hiding this comment.
Updated as string in en.ftl is as follows:
churn-error-page-message-discount-already-applied = This discount was applied to a { $productName } subscription for your account. If you still need help, contact our Support team.
bcolsson
approved these changes
Jan 22, 2026
julianpoy
reviewed
Jan 22, 2026
Comment on lines
13
to
20
| enum ChurnCancelErrorReason { | ||
| AlreadyCanceling = 'already_canceling_at_period_end', | ||
| SubscriptionNotActive = 'subscription_not_active', | ||
| SubscriptionStillActive = 'subscription_still_active', | ||
| OfferExpired = 'no_churn_intervention_found', | ||
| GeneralError = 'general_error', | ||
| RedemptionLimitExceeded = 'redemption_limit_exceeded', | ||
| } |
Member
There was a problem hiding this comment.
It looks like this is never really used as an enum, just converted to an array of strings (and casted) below. I'd probably just switch this to an array of strings as const.
julianpoy
reviewed
Jan 22, 2026
Comment on lines
308
to
311
| return { | ||
| ...result, | ||
| cancelContent, | ||
| }; |
Member
There was a problem hiding this comment.
[non-blocking] Imo we shouldn't combine return types like this. Instead return each separately.
return {
cancelChurnContentEligibility,
cancelFlowContent
}
This pull requests Adds the following churn pages and en.ftl: Error Not Found Cancel/component Updates ChurnInterventionService redeemCoupon to include churnType determineCancelChurnContentEligibility to include additional reasons (subscription_not_active, already_canceling_at_period_end, adds cmsOfferingContent when needed Updates SubscriptionManagementService to return subscription invoice information Closes PAY-3434
xlisachan
force-pushed
the
PAY-3434
branch
3 times, most recently
from
3802d41 to
0b10821
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
Issue that this pull request solves
Closes: PAY-3434
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Reason: Eligible
Mobile
Tablet
Successfully redeemed
Mobile
Tablet
Reason: Already canceling
Mobile
Tablet
Reason: Discount already applied/Redemption limit exceeded
Mobile
Tablet
Reason: Subscription not active
Mobile
Tablet
Reason: No churn found
Mobile
Tablet
