fix(payments): Updated payment providers vs methods #19920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
xlisachan
force-pushed
the
PAY-3439
branch
5 times, most recently
from
6b5861a to
01d5ee3
Compare
Because
Sentry events frequently stating the "Server Components render" error occur for the CheckoutForm component
CheckoutForm is a client component, but it is importing the Node server SDK for Stripe causing Next to try to bundle Stripe Node SDK into the client build and surfacing the Server Components render error
Validation for paymentProvider was expecting an enum
This occurred as some of the options for payment methods (e.g. Apple Pay, Google Pay) during checkout were not considered valid payment provider types.
We should distinguish payment providers and payment methods.
This pull request
Updates definition/usage of payment providers vs methods
Issue that this pull request solves
Closes: PAY-3439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
Sentry events frequently stating the "Server Components render" error occur for the CheckoutForm component
This occurred as some of the options for payment methods (e.g. Apple Pay, Google Pay) during checkout were not considered valid payment provider types.
We should distinguish payment providers and payment methods.
This pull request
Issue that this pull request solves
Closes: PAY-3439
Checklist
Put an
xin the boxes that apply