wip - wiring up new email sending #19936
Draft
+3,677
−607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshirley
reviewed
Jan 23, 2026
| account(account: { | ||
| uid: string; | ||
| email: string; | ||
| emails: Array<{ isPrimary: boolean; isVerified: boolean; email: string }>; |
Contributor
There was a problem hiding this comment.
For most cases, emails will be defined, but it's not guaranteed, should this be an optional ? and handle if it's not populated. Otherwise we run the risk of a cannot access property find of 'undefined' when filtering.
Also, and this is something I can add, but at least one place for account creation we get back an object with account.primaryEmail.email but I'm unsure if we'll see that elsewhere. I'd assume priority is primaryEmail -> emails -> email
nshirley
reviewed
Jan 23, 2026
| } { | ||
| return { | ||
| location: { | ||
| stateCode: request.app.geo.location?.state || '', |
Contributor
There was a problem hiding this comment.
There's a small helper for this too, but maybe since this is the only place it'd be used it can be removed meow? https://github.com/mozilla/fxa/blob/main/packages/fxa-shared/lib/geo-data.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still testing, but pushed for collaboration purposes.
Because
This pull request
Issue that this pull request solves
Closes: (issue number)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.