Skip to content

fix(emails): Make Done button responsive after adding email #723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
karansapolia wants to merge 1 commit into from
Closed

fix(emails): Make Done button responsive after adding email #723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/fxa-content-server/app/scripts/templates/settings/emails.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,7 @@
{{#hasSecondaryEmail}}
<button type="submit" class="settings-button email-refresh primary-button enabled" title="{{ lastCheckedTime }}">{{#t}}Refresh Status{{/t}}</button>

<button
class="settings-button {{#hasSecondaryVerifiedEmail}}cancel secondary-button enabled{{/hasSecondaryVerifiedEmail}}
{{^hasSecondaryVerifiedEmail}} disabled {{/hasSecondaryVerifiedEmail}}">
<button class="settings-button cancel secondary-button">
{{#t}}Done{{/t}}
</button>
{{/hasSecondaryEmail}}
Expand Down
1 change: 0 additions & 1 deletion packages/fxa-content-server/app/scripts/views/settings/emails.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ var View = FormView.extend({
buttonClass: this._hasSecondaryEmail() ? 'secondary-button' : 'primary-button',
emails: this._emails,
hasSecondaryEmail: this._hasSecondaryEmail(),
hasSecondaryVerifiedEmail: this._hasSecondaryVerifiedEmail(),
isPanelOpen: this.isPanelOpen(),
lastCheckedTime: this.getLastCheckedTimeString(),
newEmail: this.newEmail,
Expand Down