Enable more codecs and add a new API nestegg_read_last_packet()
#73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In gecko, AacCodecSpecificData has an attribute mMediaFrameCount, which is calculated by > Media frame count = total frame count - delay frame count - padding frame count. Nestegg already has methods to get the delay frame amount (codec_delay in nestegg_audio_params) and the padding frame amount ( nestegg_packet_discard_padding). In order to know the total frame count, we have to know the timestamp of the last packet in AAC stream. Therefore, we add a new method nestegg_read_last_packet to achieve that.
kinetiknz
approved these changes
Aug 31, 2025
Collaborator
kinetiknz
left a comment
kinetiknz
left a comment
There was a problem hiding this comment.
LGTM, just some minor nits and a question.
| } | ||
|
|
||
| int | ||
| nestegg_read_last_packet(nestegg * context, unsigned int track, |
Collaborator
There was a problem hiding this comment.
How important is the performance of this? Scanning through the entire stream could be a little expensive for large streams, if Cues are present we could improve this by scanning from the last marked Cluster. That can be a future improvement if needed, doesn't need to be changed now.
Contributor
Author
There was a problem hiding this comment.
Thanks! Then I will post another PR to improve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kinetiknz Could you help me review whether my draft is on the right track? It adds support for more codecs that may be available in Gecko, and introduces a new method which will be used to calculate the total frame count for AAC. Thanks!