Add nestegg_read_total_frames_count to read the total number of frames from Block Lacing.
#74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes from Block Lacing. Per Matroska Block Lacing [1], the number of frames in a Block can be determined by its Lacing value. This new function allows Gecko to accurately determine the total media frames in an MKV file. [1] https://www.matroska.org/technical/notes.html
Contributor
Author
|
@kinetiknz could you help me review this? In addition, I will have a separate PR to remove |
kinetiknz
requested changes
Sep 7, 2025
Collaborator
|
Thanks! I've merged this as a507ba1 (with framesOut renamed to frames_out in nestegg.h) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Matroska Block Lacing [1], the number of frames in a Block can be determined by its Lacing value. This new function allows Gecko to accurately determine the total media frames in an MKV file.
[1] https://www.matroska.org/technical/notes.html