Skip to content

Port hooks test and test with minor change to vitest #3877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eemeli merged 9 commits into from
Dec 30, 2025
Merged

Port hooks test and test with minor change to vitest #3877

eemeli merged 9 commits into from
Dec 30, 2025

Conversation

@nishitmistry
Copy link
Contributor

@nishitmistry nishitmistry commented Dec 24, 2025 •
edited
Loading

In continuation of the previous Mr #3875 for task #3768

  • ported hooks test to be compatible with vitest
  • ported other test requiring simple changes in there implementation to be compatible with vitest
  • added jsdom url for EntityDetail and EntityNavigation

@nishitmistry nishitmistry marked this pull request as draft December 24, 2025 06:37
@nishitmistry nishitmistry force-pushed the port-hooks-and-test-with-minor-change-to-vitest branch from fada1fb to a6cdcff Compare December 29, 2025 17:25
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 110 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.10%. Comparing base (070cd28) to head (8e63011).

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nishitmistry nishitmistry force-pushed the port-hooks-and-test-with-minor-change-to-vitest branch 2 times, most recently from 1727f2b to 4780764 Compare December 30, 2025 13:38
@nishitmistry nishitmistry marked this pull request as ready for review December 30, 2025 13:39
@nishitmistry nishitmistry force-pushed the port-hooks-and-test-with-minor-change-to-vitest branch from 4780764 to 5180990 Compare December 30, 2025 13:42
eemeli
eemeli approved these changes Dec 30, 2025
View reviewed changes
Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Apply the inline fix to avoid // in paths, and this is good to merge.

@nishitmistry nishitmistry requested a review from eemeli December 30, 2025 15:33
@eemeli eemeli merged commit 969d1ab into mozilla:main Dec 30, 2025
7 checks passed
@nishitmistry nishitmistry mentioned this pull request Dec 30, 2025
Merged
@nishitmistry nishitmistry deleted the port-hooks-and-test-with-minor-change-to-vitest branch January 6, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eemeli eemeli Awaiting requested review from eemeli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nishitmistry @codecov-commenter @eemeli