Bug fixes #186
Merged
Bug fixes #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 16, 2025 11:37
…s-dismiss with Blazor @OnClick functionality - Fixed collapsible sections across 6 files (Instructions, EditModal, AddModal, AdminLog, Generate, GeneratedNamesLog) - Replaced data-bs-toggle='collapse' with @OnClick handlers and C# collapse management - Replaced data-bs-dismiss='alert' with @OnClick handlers for alert dismissal - Added ToggleCollapse/GetCollapseClass methods to manage section states - Fixed EditModal @code block structure (missing closing brace) - All sections now properly expand/collapse without page reloads - All alert dismiss buttons now properly hide alerts
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request replaces Bootstrap's native collapse functionality with a custom Blazor-based collapse implementation across multiple components, improving alert dismissal logic in the EditModal component, and incrementing the project version from 5.0.0 to 5.0.1.
Key Changes:
- Implements custom collapse management using
HashSet<string>and C# methods (ToggleCollapse,GetCollapseClass) across Instructions, GeneratedNamesLog, Generate, AdminLog, AddModal, and EditModal components - Adds stateful alert dismissal with dedicated boolean flags and handler methods in EditModal
- Updates version to 5.0.1 in both programsettings.json and AzureNamingTool.csproj
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/programsettings.json | Updates tool version to 5.0.1 |
| src/AzureNamingTool.csproj | Updates project version to 5.0.1 |
| src/Components/Pages/Instructions.razor | Replaces Bootstrap collapse with custom implementation, adds ToggleCollapse and GetCollapseClass methods |
| src/Components/Pages/GeneratedNamesLog.razor | Adds custom collapse management for filter section |
| src/Components/Pages/Generate.razor | Implements custom collapse for instructions, naming guidelines, and components sections |
| src/Components/Pages/AdminLog.razor | Adds custom collapse management for admin log filter section |
| src/Components/Modals/EditModal.razor | Implements custom collapse for metadata and component sections; adds alert dismissal state management |
| src/Components/Modals/AddModal.razor | Adds custom collapse management for type metadata section |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a unified, custom implementation for collapsible UI sections throughout several modal and page components, replacing the previous reliance on Bootstrap's collapse functionality. It also improves alert dismissal logic in the
EditModalcomponent and bumps the project version.UI/UX Improvements – Collapsible Sections:
data-bs-toggle="collapse"and related attributes with a custom collapse management system acrossAddModal.razor,EditModal.razor,AdminLog.razor, andGenerate.razor. This system uses aHashSet<string>to track collapsed sections, and toggles collapse state via click handlers and helper methods (ToggleCollapse,GetCollapseClass). This results in more consistent and maintainable collapsible UI sections. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Alert Dismissal Logic:
isDangerAlertDismissed,isWarningAlertDismissed) and dismiss handlers (DismissDangerAlert,DismissWarningAlert) to allow users to dismiss alerts inEditModal.razorwithout relying on Bootstrap's alert dismissal, improving control and reactivity. [1] [2] [3] [4]Project Versioning:
5.0.0to5.0.1inAzureNamingTool.csproj.Bug Fixes