Added handler for HTTP2/PRI #178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glaslos
requested changes
Mar 9, 2025
protocols/protocols.go
Outdated
| } | ||
| // poor mans check for HTTP request | ||
| httpMap := map[string]bool{"GET ": true, "POST": true, "HEAD": true, "OPTI": true, "CONN": true} | ||
| httpMap := map[string]bool{"GET ": true, "POST": true, "HEAD": true, "OPTI": true, "CONN": true,"PRI": true} |
protocols/tcp/http.go
Outdated
|
|
||
| reader := bufio.NewReader(conn) | ||
| preface,err := reader.Peek(24) | ||
| if err==nil && bytes.Equal(preface, []byte("PRI * HTTP/2.0\r\n\r\nSM\r\n\r\n")){ |
Member
There was a problem hiding this comment.
in go we handle the error case in the conditional
Author
|
@glaslos I modified code as stated if anything needed to be still changed please let me know. |
Member
|
Please add a test for your change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #159
Key Changes
PRIinprotocols.gotohttpMapsuch that it detects HTTP/2 connectionsHandleHTTPfunction intcp/http.goPRI * HTTP/2.0\r\n\r\nSM\r\n\r\n) and checks if data matches with HTTP/2 preface@glaslos
If there are any changes to be made I am ready to modify them.