Skip to content

Conversation

@Tommy-Valletta
Copy link
Collaborator

Added the following fields to the Client Deductions Response Object:

top_level_category_guid
user_guid

@Tommy-Valletta Tommy-Valletta added the minor Minor version update label Jul 18, 2025
Copy link
Collaborator

@Gvieve Gvieve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be a ton of changes here, most of which look like cleanup, but is way more than a few additional fields. Do you mind elaborating a bit on why there are so many?

@Tommy-Valletta
Copy link
Collaborator Author

There seem to be a ton of changes here, most of which look like cleanup, but is way more than a few additional fields. Do you mind elaborating a bit on why there are so many?

I actually didn't do any of these manually. Only commands I ran were:
gco master
git fetch origin master
git pull
gco -b tv/DEVX...
*Made my changes
git status
git add .
git commit -m "..."
gpsup

Either way, we're closing this PR, right?

@Gvieve
Copy link
Collaborator

Gvieve commented Jul 18, 2025

There seem to be a ton of changes here, most of which look like cleanup, but is way more than a few additional fields. Do you mind elaborating a bit on why there are so many?

I actually didn't do any of these manually. Only commands I ran were: gco master git fetch origin master git pull gco -b tv/DEVX... *Made my changes git status git add . git commit -m "..." gpsup

Either way, we're closing this PR, right?

Perhaps your IDE might be auto-cleaning or changing things. You may have some extensions or settings doing that. I didn’t look super closely at all the changes, but just wanted to flag it. It’s good to be aware of what your tools are doing so you don’t accidentally introduce unintended (or even breaking) changes.

And yes, we should close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor Minor version update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants