-
Notifications
You must be signed in to change notification settings - Fork 0
submit week5 assignment #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
franchizi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're doing a great job!
|
|
||
| def greet(name) | ||
| "Hello, #{name}!" | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct.
|
|
||
| def ctof(temperature) | ||
| return temperature * 9.0 / 5 + 32 | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good also.
| result*= (number+1) | ||
| end | ||
| return result | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
| it "computes the factorial of 10" do | ||
| expect(factorial(10)).to eq(3628800) | ||
| end | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is properly done!
| expect(s).to eq("Ahay! Iay otgay ouyay!") | ||
| end | ||
|
|
||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
| # end | ||
| # end | ||
| # return c | ||
| # end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code in the title method looks like it would work, but how are you getting input (as in a string) for the method to operate on?
| it "doesn't pad a two-digit number" do | ||
| expect(@timer.padded(12)).to eq('12') | ||
| end | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good.
Student Ming King
Submit week5 assignment.
Thank you!