Add 5 second timeout when connecting to the home relay #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
approved these changes
Oct 14, 2025
This will let us print out a ticket even if we can't get online
eminence
force-pushed
the
online_timeout
branch
from
efd40a8 to
7594925
Compare
Contributor
Author
|
I've rebased and solved the merge conflicts. Are there any other changes you'd like to see before merging? |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let us print out a ticket even if we can't get online
This timeout value of 5 seconds was chosen based on the recommendation in the 0.93 announcement blog post.
This change should also reduce the type of confusion that we see in issues like #76