chore: update subaccount_info query #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for querying subaccount pre-state information when simulating transactions. The change enables retrieving the subaccount state both before and after applying simulated transactions.
Key changes:
- Added
pre_stateparameter to theget_subaccount_infoquery method - Introduced
PreStatemodel to represent subaccount state before transaction application - Updated the sanity check script to demonstrate the new pre-state functionality
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| sanity/engine_client.py | Added example code demonstrating the use of pre_state parameter with simulated transactions |
| nado_protocol/engine_client/types/query.py | Added PreState model and pre_state field to QuerySubaccountInfoParams and SubaccountInfoData |
| nado_protocol/engine_client/types/init.py | Exported the new PreState model |
| nado_protocol/engine_client/query.py | Updated get_subaccount_info method signature to accept pre_state parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.