chore: improve margin manager #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR enhances the margin manager by adding average entry price and estimated liquidation price calculations for cross margin positions, along with version bump to 0.3.0.
Changes:
- Added
avg_entry_priceandest_liq_pricefields toCrossPositionMetrics - Refactored indexer event retrieval into a reusable helper method
- Implemented liquidation price calculations with safeguards for long and short positions
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| pyproject.toml | Version bump from 0.2.8 to 0.3.0 |
| nado_protocol/utils/margin_manager.py | Added avg entry price and liquidation price calculations with display support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Calculate estimated liquidation price. | ||
| Formula: | ||
| - If long: oracle_price - (maint_health / amount / long_weight) |
There was a problem hiding this comment.
The formula documentation uses inconsistent operator precedence notation. The division operations should be explicitly grouped with parentheses to match the implementation: oracle_price - ((maint_health / amount) / long_weight)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.