Make CI pass with --enable-frozen-string-literal
#471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses the `warning: literal string will be frozen in the future` warnings appeared at Rails CI https://buildkite.com/rails/rails-nightly/builds/1122#019263a3-2200-4e62-a6a8-028cffa60aaf Here are the warnings appeared: ``` /usr/local/lib/ruby/gems/3.4.0+0/bundler/gems/httpclient-d57cc6d5ffee/lib/httpclient.rb:1256: warning: literal string will be frozen in the future /usr/local/lib/ruby/gems/3.4.0+0/bundler/gems/httpclient-d57cc6d5ffee/lib/httpclient/http.rb:580: warning: literal string will be frozen in the future /usr/local/lib/ruby/gems/3.4.0+0/bundler/gems/httpclient-d57cc6d5ffee/lib/httpclient/session.rb:954: warning: literal string will be frozen in the future /usr/local/lib/ruby/gems/3.4.0+0/bundler/gems/httpclient-d57cc6d5ffee/lib/httpclient/util.rb:71: warning: literal string will be frozen in the future ``` There should be some warnings remained because Rails CI does not use all of httpclient code. I'll open some pull requests later to address remaining ones. Ref: https://bugs.ruby-lang.org/issues/20205
byroot
force-pushed
the
frozen-string-literal
branch
2 times, most recently
from
d286685 to
f9ece3f
Compare
byroot
force-pushed
the
frozen-string-literal
branch
from
f9ece3f to
06070a4
Compare
Collaborator
|
Thank you. Looks good to me. |
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Feb 22, 2025
httpclient 2.9.0 has been released that supports Ruby 3.4 changes: - making `mutex_m` as bundled gem nahi/httpclient#455 nahi/httpclient#472 - Chilled strings nahi/httpclient#471 Kind of reverting rails#50911
4 tasks
JuanVqz
pushed a commit
to JuanVqz/rails
that referenced
this pull request
Feb 24, 2025
httpclient 2.9.0 has been released that supports Ruby 3.4 changes: - making `mutex_m` as bundled gem nahi/httpclient#455 nahi/httpclient#472 - Chilled strings nahi/httpclient#471 Kind of reverting rails#50911
dkani
pushed a commit
to dkani/rails
that referenced
this pull request
Mar 3, 2025
httpclient 2.9.0 has been released that supports Ruby 3.4 changes: - making `mutex_m` as bundled gem nahi/httpclient#455 nahi/httpclient#472 - Chilled strings nahi/httpclient#471 Kind of reverting rails#50911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #462, with some extra fixes and also a CI job that test with frozen string literals enabled to ensure there's no regressions.
cc @yahonda @takkanm