Make webrick a dev dependency #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not actually needed at runtime, it's only used by the test suite.
Collaborator
|
Sorry for delaying my review. Looks good. Thanks! |
yahonda
added a commit
to yahonda/rails
that referenced
this pull request
Feb 22, 2025
httpclient 2.9.0 has been released that supports Ruby 3.4 changes: - making `mutex_m` as bundled gem nahi/httpclient#455 nahi/httpclient#472 - Chilled strings nahi/httpclient#471 Kind of reverting rails#50911
4 tasks
JuanVqz
pushed a commit
to JuanVqz/rails
that referenced
this pull request
Feb 24, 2025
httpclient 2.9.0 has been released that supports Ruby 3.4 changes: - making `mutex_m` as bundled gem nahi/httpclient#455 nahi/httpclient#472 - Chilled strings nahi/httpclient#471 Kind of reverting rails#50911
dkani
pushed a commit
to dkani/rails
that referenced
this pull request
Mar 3, 2025
httpclient 2.9.0 has been released that supports Ruby 3.4 changes: - making `mutex_m` as bundled gem nahi/httpclient#455 nahi/httpclient#472 - Chilled strings nahi/httpclient#471 Kind of reverting rails#50911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not actually needed at runtime, it's only used by the test suite.
cc @takkanm