Feat/631 add slack notifications upon key ci actions #676
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
.github/workflows/deploy_ensnode.yml
Outdated
| - name: Slack Notification on Success | ||
| if: success() |
There was a problem hiding this comment.
i think if: success() unnecessary?
A default status check of success() is applied unless you include one of these functions.
.github/workflows/deploy_ensnode.yml
Outdated
| if: success() | ||
| uses: rtCamp/action-slack-notify@v2 | ||
| env: | ||
| SLACK_WEBHOOK: ${{ secrets.SLACK_WEBHOOK_URL }} |
There was a problem hiding this comment.
would it be beneficial to extract this into a shared action where the default values can be applied? username and icon are static and title/message/color(default good) can be the args. not sure if the secret can be set in the action or whether only the main workflow file has access to secrets. but otherwise that can be provided as a default as well to cut down on the duplication in each workflow we want to notify slack in
There was a problem hiding this comment.
Added new action for Slack notification. We can extend it further in the future if needed
.github/workflows/deploy_ensnode.yml
Outdated
| redeploy_service ${RAILWAY_ENVIRONMENT_ID} ${ENSRAINBOW_SVC_ID} | ||
| - name: Slack Notification on Success |
There was a problem hiding this comment.
also happy to remove the name key here, as it'll use the action name by default which is a-ok to me and minimizes our configuration
…tifications-upon-key-ci-actions
…tifications-upon-key-ci-actions
Added Github notifications on switch/deploy/release