remove mentions of vision and format #709
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
5 Skipped Deployments
|
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@notrab Appreciate these updates. Shared a few suggestions 👍 I can confirm that the unit tests that are breaking are unrelated to the changes in this PR and will need to be investigated as a separate effort some other time.
apps/namegraph.dev/lib/utils.ts
Outdated
| export const ExternalLinkHosts = { | ||
| "Vision": "Vision", | ||
| "ENSDomains": "ENSDomains" | ||
| Vision: "Vision", |
apps/namegraph.dev/lib/utils.ts
Outdated
| case ExternalLinkHosts.ENSDomains: | ||
| return `https://app.ens.domains/${name}` | ||
| return `https://app.ens.domains/${name}`; | ||
| case ExternalLinkHosts.Vision: |
There was a problem hiding this comment.
Appreciate your review here
| case ExternalLinkHosts.ENSDomains: | ||
| return <EnsOutlineIcon className="w-8 h-8 hover:scale-110 transition" />; | ||
| case ExternalLinkHosts.Vision: | ||
| return <EnsVisionIcon className="w-16 h-16 hover:scale-110 transition" />; |
There was a problem hiding this comment.
Please:
- Also remove this
EnsVisionIconcomponent. - Search all our files (both file names and file contents) for "vision" or "Vision" or etc.. to find anything else we missed.
| switch (host) { | ||
| case ExternalLinkHosts.ENSDomains: | ||
| return <EnsOutlineIcon className="w-8 h-8 hover:scale-110 transition" />; | ||
| case ExternalLinkHosts.Vision: |
There was a problem hiding this comment.
We want to replace the link to Vision with a link (and icon) for OpenSea instead.
vercel
bot
temporarily deployed
to
Preview – examples.nameguard.io
vercel
bot
temporarily deployed
to
Preview – examples.nameguard.io
lightwalker-eth
left a comment
lightwalker-eth
left a comment
There was a problem hiding this comment.
@notrab Thanks for your help with this 👍
vision(example implementation banners).formatwhich hasn't been done in a while on this repo.