Fix nasa/CF#334, Temporary files possible filename conflict #472
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Modified the creation of temporary filenames in function
CF_CFDP_R_Init()to have the name of the file be defined as the concatenation of the source entity ID and the sequence number to avoid filename conflicts.Fixes issue #334
Testing performed
cd cFSgit submodule initgit submodule updategit submodule initgit submodule updatecp cfe/cmake/Makefile.sample Makefilecp -r cfe/cmake/sample_defs sample_defslist(APPEND MISSION_GLOBAL_APPLIST sample_app sample_lib cf)make SIMULATION=native ENABLE_UNIT_TESTS=true BUILDTYPE=debug OMIT_DEPRECATED=true prepCFE_APP, cf, CF_AppMain, CF, 80, 16384, 0x0, 0;make installmake testExpected behavior changes
Temporary filenames created via
CF_CFDP_R_Init()should now have filenames be a concatenation of their source entity ID and sequence numberSystem(s) tested on
Ubuntu 20.04.6
Contributor Info - All information REQUIRED for consideration of pull request
Lukas Kebuladze, GSFC