Angular 13 → 20 Upgrade (iaro/upgrade-ng20) #644
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Preview first few lines of text.
Preview first few lines of text.
…olve Angular 19 build errors
Resolved conflict in config.json: - Kept disableJSDraw: false to enable both Ketcher and JSDraw editors - Removed duplicate restApiPrefix entry
- Update Angular core packages from 19.2.15 to 20.3.14 - Update Angular CLI from 19.2.19 to 20.3.12 - Update TypeScript from 5.5.4 to 5.9.3 - Update moduleResolution to 'bundler' in tsconfig.json - Move DOCUMENT imports from @angular/common to @angular/core
…jectionParameters - Remove obsolete Angular compiler flags (aot, buildOptimizer, enableIvy) - Fix field initialization: move DI-dependent fields to constructor (10 services) - Remove duplicate property declarations in child classes (bdnum, product fields) - Modernize RxJS: replace toPromise() with lastValueFrom() (2 files) - Fix DI decorators: @Injectable → @directive for base classes with @Input/@output - Migrate Sass: @import → @use in 8 SCSS files for Dart Sass 3.0 compatibility - Remove unused dependencies: classlist.js, tslint, codelyzer, core-js - Add missing sprintf-js dependency - Clean up unused imports and variables (admin.component, substance-application.component)
Property already inherited from SubstanceDetailsBaseTableDisplay parent class. Removed redundant @input() declaration and unused Input import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the GSRS Frontend to Angular 20 on top of
development_3.0and includes the required migration with zero build errors and modernizing the codebase.Highlights:
Upgraded Angular 13 → 20 (all intermediate versions)
Fixed 1,973 TypeScript errors — builds now pass cleanly
Updated dependencies: Angular 20.3.14, Material 20.2.14 (MDC migration completed), TypeScript 5.9.3, RxJS 7.8.1, PrimeNG 20+
Replaced deprecated .toPromise() → lastValueFrom()
Migrated Sass from @import → @use (no deprecation warnings)
Modernized build system: ES2022 target, Bundler module resolution
Enabled strictInjectionParameters (Strict DI)
Impact
26+ files updated across configs, services, components, and styles
Production bundle: 7.13 MB raw / 1.17 MB gzip
Build time: ~25 seconds, fully successful