-
Notifications
You must be signed in to change notification settings - Fork 2
Add TICON-4 data #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TICON-4 data #16
Conversation
514bda0 to
5d941f9
Compare
ed6768c to
b8fd033
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds functionality to import 4,838 global tide stations from the TICON-4 (TIdal CONstants based on GESLA-4) dataset. The implementation includes a bash script to download the data, a TypeScript module to parse and convert the data to the repository's station JSON schema, and a new utility module for computing tidal datums.
Key changes:
- New import tooling for TICON-4 dataset with automatic data download and processing
- New datum computation utilities using synthetic tidal predictions
- Updated @neaps/tide-predictor dependency to version 0.3.0 to support additional harmonic constituents
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/import-ticon | Bash script that downloads TICON-4 data and invokes the TypeScript import script |
| tools/import-ticon.ts | TypeScript module that parses TICON-4 CSV files and converts stations to JSON schema |
| tools/datum.ts | New utility module for computing tidal datums from harmonic constituents using synthetic predictions |
| package.json | Updates @neaps/tide-predictor dependency from 0.2.1 to 0.3.0 |
| .gitignore | Adds tmp directory to exclude downloaded data from version control |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
679ff9b to
5bef153
Compare
…so copilot can focus on more meaningful feedback
I'm going to leave this for now. Later I can add a way to load data by source or filter out likely. |
This pull request adds a script to import stations from TICON-4, TIdal CONstants based on GESLA-4 sea-level records.
It includes 4,838 global stations.
TODO:
Resolve duplicates between NOAA/TICON. It might make sense to just skip any that are from NOAA in TICON, but I want to compare the list and see if there are any differences.